Open
Conversation
Examples show counter without _total suffix, fixed. For unit we need to mention that in can be infix as well. Some minor fixup. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added
the
priority/p3
dashpole
approved these changes
Mar 18, 2026
bwplotka
approved these changes
Mar 20, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! just tiny nit, otherwise LGTM
| ### MetricFamily | ||
|
|
||
| There MUST NOT be an explicit separator between MetricFamilies. The next MetricFamily MUST be signalled with either metadata or a new sample metric name which cannot be part of the previous MetricFamily. | ||
| There MUST NOT be an explicit separator between MetricFamilies. The next MetricFamily MUST be signalled with either metadata or a new Metric name which cannot be part of the previous MetricFamily. |
Member
There was a problem hiding this comment.
Suggested change
| There MUST NOT be an explicit separator between MetricFamilies. The next MetricFamily MUST be signalled with either metadata or a new Metric name which cannot be part of the previous MetricFamily. | |
| There MUST NOT be an explicit separator between MetricFamilies. The next MetricFamily MUST be signalled with either metadata or a new Metric name for a new MetricFamily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples show counter without _total suffix, fixed. For unit we need to mention that in can be infix as well. Some minor fixup.